Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move some gc tests back to parallel/, unmark flaky #23356

Closed
wants to merge 1 commit into from
Closed

test: move some gc tests back to parallel/, unmark flaky #23356

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Oct 9, 2018

These should no longer be flaky after the libuv update.

Refs: #23336

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1182/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 9, 2018
@addaleax
Copy link
Member Author

addaleax commented Oct 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17706/

@refack
Copy link
Contributor

refack commented Oct 9, 2018

Wait till after C&L, just to reduce chance of noise?

@addaleax
Copy link
Member Author

addaleax commented Oct 9, 2018 •
edited
Loading

I’m okay with waiting until after C&L if you’re worried about flakiness returning?

Trott
Trott approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we won't still see timeouts in parallel, but if we do, then we just move 'em back to sequential. LGTM.

@addaleax
Copy link
Member Author

ARM fanned again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3941/

@Trott
Copy link
Member

Trott commented Oct 10, 2018

ARM fanned yet again: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3943/

@Trott
Copy link
Member

Trott commented Oct 10, 2018 •
edited
Loading

Pi2 is stubbornly failing test-http2-session-timeout but only here. It makes me want to believe it could actually be related to this change, but that seems implausible.

Rebuild: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3957/ ✔️

@refack
Copy link
Contributor

refack commented Oct 10, 2018

Pi2 is stubbornly failing test-http2-session-timeout but only here. It makes me want to believe it could actually be related to this change, but that seems implausible.

I think Jenkins uses some sort of worker stickiness, so the 3 failures were on the same machine (https://ci.nodejs.org/computer/test-requireio_joeyvandijk-debian9-armv7l_pi2-2/)
https://ci.nodejs.org/job/node-test-binary-arm/3768/RUN_SUBSET=3,label=pi2-docker/
https://ci.nodejs.org/job/node-test-binary-arm/3777/RUN_SUBSET=3,label=pi2-docker/
https://ci.nodejs.org/job/node-test-binary-arm/3779/RUN_SUBSET=3,label=pi2-docker/
So I took it offline, for the time being.

@addaleax
test: move some gc tests back to parallel/, unmark flaky
2d847d2 
These should no longer be flaky after the libuv update.

Refs: nodejs#23336
@addaleax
Copy link
Member Author

Landed in 627bcf7

@addaleax addaleax closed this Oct 12, 2018
@addaleax addaleax deleted the test-gc-back branch October 12, 2018 21:28
addaleax added a commit that referenced this pull request Oct 12, 2018
@addaleax
test: move some gc tests back to parallel/, unmark flaky
627bcf7 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott pushed a commit that referenced this pull request Oct 13, 2018
@addaleax @Trott
test: move some gc tests back to parallel/, unmark flaky
35f9218 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2018
@addaleax @targos
test: move some gc tests back to parallel/, unmark flaky
dc52a51 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@addaleax @jasnell
test: move some gc tests back to parallel/, unmark flaky
208ee3e 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@addaleax @MylesBorins
test: move some gc tests back to parallel/, unmark flaky
65ae332 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@addaleax @rvagg
test: move some gc tests back to parallel/, unmark flaky
5287d06 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@addaleax @MylesBorins
test: move some gc tests back to parallel/, unmark flaky
a29c8da 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @nodejs-github-bot @refack @Trott @jasnell @thefourtheye @cjihrig @richardlau @devsnek @BridgeAR